Version 0.8: maintanance #42
Conversation
There was a problem hiding this comment.
@cloudhead also market the specific place with the fix (the rest is chore)
| Ok(0) | ||
| } else { | ||
| Err(io::ErrorKind::Interrupted.into()) | ||
| } | ||
| } |
There was a problem hiding this comment.
@cloudhead important!
Before, I was unconditionally passing to the inner session write operation. Now, I do that only if the handshake in the current session is complete
There was a problem hiding this comment.
Ah that means you can't write before the handshake anymore? That sounds good.
There was a problem hiding this comment.
Nope, you also was not being able to write before the handshake before...
| fn artifact(&self) -> Option<Self::Artifact> { Some(()) } | ||
| fn artifact(&self) -> Option<Self::Artifact> { | ||
| match self { | ||
| Socks5::Initial(addr, false) if !addr.requires_proxy() => Some(addr.clone()), |
There was a problem hiding this comment.
This line is the actual bugfix: we return artifact signifying successful handshake if the proxy is not used and not needed. Thus, we do not run a empty handshake and successfully activate handshake in up-level session.
No description provided.