fix(other): php warning: undefined array key 'x-profile-id' #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow243
requested changes
Apr 18, 2025
| @@ -75,6 +75,9 @@ function send_scheduled_message($handler, $imapMailbox, $folder, $msg_id, $send_ | |||
| } | |||
|
|
|||
| if (new DateTime($msg_headers['X-Schedule']) <= new DateTime() || $send_now) { | |||
| if (! isset($msg_headers['X-Profile-ID'])) { | |||
There was a problem hiding this comment.
Put the condition at the same position as X-Schedule at line 73 and use empty instead of isset
christer77
force-pushed
the
PHP-Warning-Undefined-array-key-X-Profile-ID
branch
from
8a7f1ed to
aa41843
Compare
Shadow243
reviewed
Apr 23, 2025
| @@ -70,11 +70,18 @@ function send_scheduled_message($handler, $imapMailbox, $folder, $msg_id, $send_ | |||
| $msg_headers = $imapMailbox->get_message_headers($folder, $msg_id); | |||
| $mailbox_details = $imapMailbox->get_config(); | |||
| try { | |||
| if (empty($msg_headers['X-Schedule'])) { | |||
| if (! isset($msg_headers['X-Schedule'])) { | |||
There was a problem hiding this comment.
@christer77 empty has isset and other condition. keep empty not isset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP Warning: Undefined array key "X-Profile-ID" in
...\cypht\modules\smtp\functions.php on line 81