Skip to content

Conversation

@camilevahviraki
Copy link
Contributor

@camilevahviraki camilevahviraki commented Oct 3, 2025

🍰 Pullrequest

Issues

current step

Screencast.from.2025-10-14.02-53-31.webm

Next Step

  • add Dry run button and functionality to sieve filter.

@camilevahviraki camilevahviraki marked this pull request as draft October 3, 2025 23:44
@camilevahviraki camilevahviraki force-pushed the cypht-filter-start-from-one branch 2 times, most recently from eb3cbd6 to 668a7ce Compare October 4, 2025 01:00
@camilevahviraki camilevahviraki force-pushed the cypht-filter-start-from-one branch from 668a7ce to b69b0d1 Compare October 4, 2025 01:02
@camilevahviraki camilevahviraki force-pushed the cypht-filter-start-from-one branch 2 times, most recently from 5d113a2 to dcdf0cd Compare October 14, 2025 09:58
@camilevahviraki camilevahviraki force-pushed the cypht-filter-start-from-one branch 3 times, most recently from b6c50e7 to 400058b Compare October 27, 2025 22:29
@camilevahviraki camilevahviraki force-pushed the cypht-filter-start-from-one branch from 400058b to 53d564b Compare October 27, 2025 22:38
@camilevahviraki camilevahviraki marked this pull request as ready for review October 27, 2025 22:48
@marclaporte marclaporte requested a review from kroky October 28, 2025 01:37
}
}

if ($this->get('sieve_filters_enabled')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to check for this. Whenever you find yourself in the situation to check if a module is enabled, you should immediately think if you put the code in the right module. This code needs to go in sievefilters module - it can be an output module that is executed after this one here. If you need to put the content in a specific place in the middle of the headers section, add a placeholder for it or insert after an element.

@camilevahviraki camilevahviraki force-pushed the cypht-filter-start-from-one branch 2 times, most recently from 2a29310 to 80a8161 Compare October 30, 2025 22:10
@camilevahviraki camilevahviraki force-pushed the cypht-filter-start-from-one branch from 80a8161 to cd4c129 Compare October 30, 2025 22:12
@camilevahviraki camilevahviraki marked this pull request as draft October 30, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants