Skip to content

Conversation

@Danelif
Copy link
Member

@Danelif Danelif commented Oct 11, 2025

This PR implements comprehensive MTA-STS (Mail Transfer Agent Strict Transport Security) and TLS-RPT (TLS Reporting) support in Cypht, addressing #337.

@Danelif Danelif changed the title feat(backend):Implement MTA-STS and TLS-RPT support for email security visibility feat(backend): Implement MTA-STS and TLS-RPT support for email security visibility Oct 11, 2025
@Danelif Danelif changed the title feat(backend): Implement MTA-STS and TLS-RPT support for email security visibility feat(backend): implement MTA-STS and TLS-RPT support for email security visibility Oct 11, 2025
@Danelif Danelif force-pushed the mta-sts-implementation branch 2 times, most recently from 73b0247 to d09124e Compare October 11, 2025 01:41
@Danelif Danelif marked this pull request as ready for review October 21, 2025 07:16
@marclaporte marclaporte requested a review from kroky October 21, 2025 09:47
* Output MTA-STS status indicator in compose form
* @subpackage mta_sts/output
*/
class Hm_Output_mta_sts_status_indicator extends Hm_Output_Module {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the checks and status indicator don't we need to update our hm-smtp functionality to work with STS? Example concerning point that I don't see implemented: https://datatracker.ietf.org/doc/html/rfc8461#section-5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing RFC 8461 Section 5 (actual SMTP client enforcement) would require modifying the hm-smtp.php SMTP client to:

  1. Verify MX records match the MTA-STS policy
  2. Enforce TLS connections only
  3. Validate certificate names against policy
  4. Handle policy fetch failures

This is a significantly larger feature that would need to be addressed as a separate issue/PR, as it changes core email sending behavior and could break existing functionality if not implemented carefully.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the purpose of implementing the RFC in 20 or 30%. It will be confusing to the user to enable something that's not fully implemented/working. It is better to address the full implementation in one MR here and test it well before merging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, let me work on that !

@Danelif Danelif force-pushed the mta-sts-implementation branch from fa5966d to 31a26b1 Compare November 3, 2025 08:38
@Danelif Danelif force-pushed the mta-sts-implementation branch from dc61c9d to 13638ce Compare November 3, 2025 09:31
@Danelif Danelif force-pushed the mta-sts-implementation branch from 13638ce to ae87509 Compare November 3, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants