-
Notifications
You must be signed in to change notification settings - Fork 194
feat(backend): implement MTA-STS and TLS-RPT support for email security visibility #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
73b0247 to
d09124e
Compare
| * Output MTA-STS status indicator in compose form | ||
| * @subpackage mta_sts/output | ||
| */ | ||
| class Hm_Output_mta_sts_status_indicator extends Hm_Output_Module { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the checks and status indicator don't we need to update our hm-smtp functionality to work with STS? Example concerning point that I don't see implemented: https://datatracker.ietf.org/doc/html/rfc8461#section-5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementing RFC 8461 Section 5 (actual SMTP client enforcement) would require modifying the hm-smtp.php SMTP client to:
- Verify MX records match the MTA-STS policy
- Enforce TLS connections only
- Validate certificate names against policy
- Handle policy fetch failures
This is a significantly larger feature that would need to be addressed as a separate issue/PR, as it changes core email sending behavior and could break existing functionality if not implemented carefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the purpose of implementing the RFC in 20 or 30%. It will be confusing to the user to enable something that's not fully implemented/working. It is better to address the full implementation in one MR here and test it well before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, let me work on that !
fa5966d to
31a26b1
Compare
dc61c9d to
13638ce
Compare
13638ce to
ae87509
Compare
This PR implements comprehensive MTA-STS (Mail Transfer Agent Strict Transport Security) and TLS-RPT (TLS Reporting) support in Cypht, addressing #337.