feat(other): integrate advanced search into saved searches module set #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroky
reviewed
Oct 13, 2025
|
@IrAlfred thanks, it looks good but can you please add some unit/integration tests to cover the new functionality? |
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
2 times, most recently
from
77eebbe to
abce26c
Compare
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
from
abce26c to
afa4d24
Compare
kroky
reviewed
Oct 17, 2025
kroky
reviewed
Oct 17, 2025
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
from
afa4d24 to
c893f4b
Compare
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
from
c893f4b to
9d1500b
Compare
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
from
9d1500b to
169e1b4
Compare
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
5 times, most recently
from
f8cffb1 to
66a5c1e
Compare
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
from
66a5c1e to
9c34d60
Compare
|
@IrAlfred thanks, I will need some time to review. Will get back to you next week. |
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
from
9c34d60 to
54d1fda
Compare
|
@IrAlfred please take a look at the coverage report failing: https://github.com/cypht-org/cypht/actions/runs/19029638869/job/54340356825 The github action should be updated to match the refactoring you have done. Can you take a look, please? |
Yes, I work on it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #306