Skip to content

fix(other): fix some GitHub module issues #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
IrAlfred wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(other): fix some GitHub module issues #1739

IrAlfred wants to merge 2 commits into from

Conversation

@IrAlfred
Copy link
Member

@IrAlfred IrAlfred commented Oct 12, 2025

This PR addresses the following issues:

  • "Undefined array key 1" errors in GitHub "All" page (?page=message_list&list_path=github_all). The Individual repo pages are in the following format (?page=message_list&list_path=github_owner/repo). The issue arises when GitHub repositories are not in expected "owner/repo" format.
  • "Call to a member function search() on false" when no IMAP server is not configured. The fix allows GitHub module to work independently without IMAP setup

@IrAlfred IrAlfred force-pushed the fix-some-github-module-issues branch from fe26b5f to 6653bfa Compare October 12, 2025 19:25
@IrAlfred IrAlfred changed the title Fix some GitHub module issues fix(github): fix some GitHub module issues Oct 12, 2025
@IrAlfred IrAlfred changed the title fix(github): fix some GitHub module issues fix(other): fix some GitHub module issues Oct 12, 2025
@IrAlfred IrAlfred requested a review from kroky October 12, 2025 19:36
kroky
kroky reviewed Oct 13, 2025
View reviewed changes
kroky
kroky reviewed Oct 13, 2025
View reviewed changes
@IrAlfred IrAlfred force-pushed the fix-some-github-module-issues branch from 6653bfa to 2c07ac3 Compare December 3, 2025 21:32
@IrAlfred IrAlfred force-pushed the fix-some-github-module-issues branch from 2c07ac3 to e288597 Compare December 3, 2025 21:36
@IrAlfred IrAlfred requested a review from kroky December 3, 2025 21:45
kroky
kroky reviewed Dec 4, 2025
View reviewed changes
modules/imap/handler_modules.php
foreach ($ids as $key => $id) {
$details = Hm_IMAP_List::dump($id);
$mailbox = Hm_IMAP_List::get_connected_mailbox($id, $this->cache);
if (!$mailbox || !$mailbox->authed()) {
Copy link
Member

@kroky kroky Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a mailbox is configured but inaccessible at the moment, we should show an error to the user with details about which mailbox is inaccessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroky kroky kroky left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IrAlfred @kroky