fix(other): fix some GitHub module issues #1739
Conversation
IrAlfred
force-pushed
the
fix-some-github-module-issues
branch
from
fe26b5f to
6653bfa
Compare
IrAlfred
changed the title
IrAlfred
changed the title
| } | ||
|
|
||
| if (empty($ids)) { | ||
| return; |
There was a problem hiding this comment.
This method outputs some data which other modules expect to use. If you return early, that output data will not be available. What is the problem of ids being empty? The code that follows should just work and output some empty/default data.
| foreach ($ids as $key => $id) { | ||
| $details = Hm_IMAP_List::dump($id); | ||
| $mailbox = Hm_IMAP_List::get_connected_mailbox($id, $this->cache); | ||
| if (!$mailbox) { |
There was a problem hiding this comment.
This seems like we are masking a deeper problem. Why would the mailbox be not present? If there is a problem connecting or something else, we should send feedback to the user, at least.
There was a problem hiding this comment.
This seems like we are masking a deeper problem. Why would the mailbox be not present? If there is a problem connecting or something else, we should send feedback to the user, at least.
Let me investigate more deeper about this !
2 participants
This PR addresses the following issues: