feat(other): persist Bcc header in sent and draft messages #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrAlfred
force-pushed
the
add-bcc-field-to-saved-fields
branch
from
8581edc to
a34901a
Compare
|
Not sure I understand the purpose here. What's the problem of storing a draft with BCC header that makes you use a custom X- header? |
I used custom x- header instead of standard bcc header for privacy protection. Standard BCC headers must never appear in the actual email sent to recipients. This actual x- header is needed only for the users to see their own bcc information when viewing drafts and sent items. I tried to follow the pattern existing in cypht for X-Auto-Bcc. What do you suggest, I may be wrong. |
IrAlfred
force-pushed
the
add-bcc-field-to-saved-fields
branch
from
a34901a to
89346c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where Bcc recipients were missing from saved email headers.