fix(backend): ews preserve quoted-printable for Latin-1 safe text and fix attachment filenames #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow243
changed the title
kambereBr
force-pushed
the
enh-ews-msg-encoding
branch
from
14ffe1a to
01f3abd
Compare
…WS::supports_dsn()"
kroky
reviewed
Oct 29, 2025
| * @param string $message The MIME message from Hm_MIME_Msg | ||
| * @return string Modified message with ISO-8859-1 where safe | ||
| */ | ||
| private function use_iso_if_safe($message) { |
There was a problem hiding this comment.
This whole function seems very hacky and low-level. Why do you need to convert a universally available encoding like UTF-8 to something that doesn't even support more than a few hundreds of characters?
If you experience a specific edge case with Exchange, let's discuss what can be done but this conversion certainly looks very suspicious to do on the client side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.