fix(module/smtp): honor starttls mode instead of implicit tls #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affinitytechworks
changed the title
|
Thank you @affinitytechworks for your first contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypht currently treats any truthy
default_smtp_tlsvalue as a request for an implicit TLS socket. When the configuration setsstarttls, the client still opens a TLS session immediately, so submission servers on 587 see a ClientHello before STARTTLS is negotiated. This patch normalizes the string value and keeps implicit TLS limited totls/ssl/true, allowingstarttlsto follow the upgrade flow as intended.