Skip to content

Conversation

@AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 29, 2025

Additional details

Updates WebKit to version 26 as previous versions are no longer available. There are some behavior changes with the update, some which are commented on the PR.

It looks like there is some cookie ordering inconsistencies between the linux/mac builds of webkit. In order to make this consistent, we check for a strict domain match when running getCookie and if no match is found, we then fall back to the apex domain.

Additionally, now that we are updating WebKit, we can now update from Debian Bullseye (Debian 11) to Debian Trixie (Debian 13). The cypress-docker-images PR to add trixie base-internal images is cypress-io/cypress-docker-images#1440

Steps to test

How has the user experience changed?

PR Tasks


Note

Upgrades WebKit (playwright-webkit) and switches CI/Docker images to Debian Trixie, adding strict-domain cookie matching with apex fallback and updating tests/changelog accordingly.

  • WebKit / Cookies:
    • Update playwright-webkit to 1.56.1 (and lockfile).
    • Implement strict-domain cookie matching in cookieMatches() (optional { strictDomain: true }).
    • webkit-automation: getCookie() first matches exact domain, falls back to apex; normalize cookie props unchanged.
  • CI/CD & Docker:
    • Migrate base images from Bullseye to Trixie: new anchors base-internal-trixie, base-internal-yarn-berry in .circleci and image refs in docker-compose.yml and system tests.
    • Minor pipeline comment fix regarding Debian 11 glibc note.
  • Tests:
    • Add unit tests for strict domain matching; adjust cookie tests (stable sorting) and system test image refs.
  • Docs/Changelog:
    • Changelog: WebKit now prefers fully qualified cookie domain, falls back to apex.
    • Electron upgrade doc: update image name examples to -trixie.

Written by Cursor Bugbot for commit 2e64deb. This will update automatically on new commits. Configure here.

@AtofStryker AtofStryker self-assigned this Oct 29, 2025
@cypress
Copy link

cypress bot commented Oct 29, 2025

cypress    Run #67005

Run Properties:  status check passed Passed #67005  •  git commit 2e64deb26a: misc: add changelog item
Project cypress
Branch Review chore/update_playwright_webkit
Run status status check passed Passed #67005
Run duration 19m 15s
Commit git commit 2e64deb26a: misc: add changelog item
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 9
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26755
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  97.98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

@AtofStryker AtofStryker force-pushed the chore/update_playwright_webkit branch from 55fdf55 to 601e355 Compare October 30, 2025 02:53
match first when calling getCookie and falling back to apex domain
@AtofStryker AtofStryker force-pushed the chore/update_playwright_webkit branch from 601e355 to 7295535 Compare October 30, 2025 02:57
@AtofStryker AtofStryker changed the title chore (draft): update playwright-webkit from 1.24.2 to 1.56.1 chore: update playwright-webkit from 1.24.2 to 1.56.1 and base-internal image from Debian Bullseye to Debian Trixie Oct 30, 2025
@MikeMcC399
Copy link
Contributor

@AtofStryker

@AtofStryker
Copy link
Contributor Author

@AtofStryker

@MikeMcC399 I don't think for the cypress-io/cypress jobs this is a blocker but could be wrong, but it's likely a blocker when we build the binary. Going to confirm with @ryanthemanuel.

@jennifer-shehane jennifer-shehane self-requested a review October 30, 2025 13:42
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AtofStryker Question around whether this requires a changelog entry.

@AtofStryker
Copy link
Contributor Author

@MikeMcC399 it looks like the v8 snapshot issues are a runtime issue and not a build issue and doesn't appear to block building of the binary, so this should go ahead and work, though it doesn't close #32192

@AtofStryker AtofStryker changed the title chore: update playwright-webkit from 1.24.2 to 1.56.1 and base-internal image from Debian Bullseye to Debian Trixie misc: update playwright-webkit from 1.24.2 to 1.56.1 and base-internal image from Debian Bullseye to Debian Trixie Oct 30, 2025
@AtofStryker AtofStryker force-pushed the chore/update_playwright_webkit branch from c22fd72 to 2e64deb Compare October 30, 2025 15:54
@AtofStryker AtofStryker merged commit 34fe1ae into develop Oct 30, 2025
11 of 52 checks passed
@AtofStryker AtofStryker deleted the chore/update_playwright_webkit branch October 30, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants