-
Notifications
You must be signed in to change notification settings - Fork 3.4k
misc: update playwright-webkit from 1.24.2 to 1.56.1 and base-internal image from Debian Bullseye to Debian Trixie
#32852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/update_playwright_webkit
|
| Run status |
|
| Run duration | 19m 15s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
9
|
|
|
1102
|
|
|
4
|
|
|
26755
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
97.98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
55fdf55 to
601e355
Compare
match first when calling getCookie and falling back to apex domain
601e355 to
7295535
Compare
playwright-webkit from 1.24.2 to 1.56.1playwright-webkit from 1.24.2 to 1.56.1 and base-internal image from Debian Bullseye to Debian Trixie
|
@MikeMcC399 I don't think for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AtofStryker Question around whether this requires a changelog entry.
|
@MikeMcC399 it looks like the v8 snapshot issues are a runtime issue and not a build issue and doesn't appear to block building of the binary, so this should go ahead and work, though it doesn't close #32192 |
playwright-webkit from 1.24.2 to 1.56.1 and base-internal image from Debian Bullseye to Debian Trixieplaywright-webkit from 1.24.2 to 1.56.1 and base-internal image from Debian Bullseye to Debian Trixie
c22fd72 to
2e64deb
Compare
Additional details
Updates WebKit to version 26 as previous versions are no longer available. There are some behavior changes with the update, some which are commented on the PR.
It looks like there is some cookie ordering inconsistencies between the linux/mac builds of webkit. In order to make this consistent, we check for a strict domain match when running
getCookieand if no match is found, we then fall back to the apex domain.Additionally, now that we are updating WebKit, we can now update from Debian Bullseye (Debian 11) to Debian Trixie (Debian 13). The
cypress-docker-imagesPR to addtrixiebase-internalimages is cypress-io/cypress-docker-images#1440Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Upgrades WebKit (playwright-webkit) and switches CI/Docker images to Debian Trixie, adding strict-domain cookie matching with apex fallback and updating tests/changelog accordingly.
playwright-webkitto1.56.1(and lockfile).cookieMatches()(optional{ strictDomain: true }).webkit-automation:getCookie()first matches exact domain, falls back to apex; normalize cookie props unchanged.base-internal-trixie,base-internal-yarn-berryin.circleciand image refs indocker-compose.ymland system tests.-trixie.Written by Cursor Bugbot for commit 2e64deb. This will update automatically on new commits. Configure here.