internal: (studio) add indication in the console in local development that watch mode has detected a change #31824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that watch mode has detected a change
There was a problem hiding this comment.
Pull Request Overview
Adds a console notification when the studio manager finishes reloading in watch mode to improve local development feedback.
- Awaits
studioManagerPromisebefore proceeding in the reload handler - Logs
"Studio manager reloaded"to the console - Disables the ESLint
no-consolerule inline for this log
Comments suppressed due to low confidence (1)
packages/server/lib/cloud/studio/StudioLifecycleManager.ts:286
- There’s no test covering the new reload notification; consider adding a unit or integration test to assert that the console message is emitted when changes are detected.
// eslint-disable-next-line no-console
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/internal/add-indication-that-watching-has-detected-a-change
|
| Run status |
|
| Run duration | 10m 03s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
694
|
Skipped
|
0
|
Passing
|
130
|
| View all changes introduced in this branch ↗︎ | |
mschile
reviewed
Jun 5, 2025
mschile
approved these changes
Jun 5, 2025
ryanthemanuel
deleted the
ryanm/internal/add-indication-that-watching-has-detected-a-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Add indication in the console in local development that watch mode has detected a change
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?