Skip to content

chore: add license field to get rid of 'warning package.json: No license field' #32829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
+37 −1
Open

chore: add license field to get rid of 'warning package.json: No license field' #32829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1be59a
chore: add license field to get rid of 'warning package.json: No lice…
jennifer-shehane Oct 27, 2025
2000372
eslintignore updates
jennifer-shehane Oct 27, 2025
35cf081
Merge branch 'develop' into add-license-fields
jennifer-shehane Oct 28, 2025
85ad810
alphabetize package.json field
jennifer-shehane Oct 30, 2025
f69eb48
Merge branch 'develop' into add-license-fields
jennifer-shehane Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
"files": [
"dist"
],
"license": "MIT",
"nx": {
"implicitDependencies": [
"@packages/data-context"
Expand Down
1 change: 1 addition & 0 deletions packages/config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"esm/*"
],
"types": "cjs/index.d.ts",
"license": "MIT",
"module": "esm/index.js",
"nx": {}
}
3 changes: 2 additions & 1 deletion packages/data-context/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,5 +120,6 @@
"schemas",
"graphql"
],
"types": "src/index.ts"
"types": "src/index.ts",
"license": "MIT"
}
1 change: 1 addition & 0 deletions packages/driver/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
"files": [
"patches"
],
"license": "MIT",
"workspaces": {
"nohoist": [
"*"
Expand Down
1 change: 1 addition & 0 deletions packages/electron/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,6 @@
"lint-staged": {
"**/*.{js,jsx,ts,tsx}": "eslint --fix"
},
"license": "MIT",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/errors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,6 @@
"lint-staged": {
"**/*.{js,jsx,ts,tsx,json}": "eslint --fix"
},
"license": "MIT",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"peerDependencies": {
"eslint": "^9.31.0"
},
"license": "MIT",
"lint-staged": {
"**/*.{js,jsx,ts,tsx,json}": "eslint --fix"
}
Expand Down
1 change: 1 addition & 0 deletions packages/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"lib"
],
"types": "index.d.ts",
"license": "MIT",
"nx": {
"targets": {
"build": {
Expand Down
1 change: 1 addition & 0 deletions packages/extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"lib-dist",
"theme"
],
"license": "MIT",
"nx": {
"implicitDependencies": [
"@packages/server",
Expand Down
1 change: 1 addition & 0 deletions packages/frontend-shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
"vue-tsc": "^2.0.19",
"wonka": "^4.0.15"
},
"license": "MIT",
"module": "es2020",
"workspaces": {
"nohoist": [
Expand Down
1 change: 1 addition & 0 deletions packages/https-proxy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"esm/*"
],
"types": "cjs/index.d.ts",
"license": "MIT",
"module": "esm/index.js",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/launcher/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"lib"
],
"types": "index.ts",
"license": "MIT",
"nx": {
"implicitDependencies": [
"@packages/data-context"
Expand Down
1 change: 1 addition & 0 deletions packages/launchpad/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
"files": [
"dist"
],
"license": "MIT",
"nx": {
"implicitDependencies": [
"@packages/frontend-shared",
Expand Down
1 change: 1 addition & 0 deletions packages/net-stubbing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@
"files": [
"lib"
],
"license": "MIT",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/network-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"esm"
],
"types": "./cjs/index.d.ts",
"license": "MIT",
"module": "esm/index.js",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/network/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,6 @@
"esm"
],
"types": "./cjs/index.d.ts",
"license": "MIT",
"module": "esm/index.js"
}
1 change: 1 addition & 0 deletions packages/packherd-require/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,6 @@
"src/require.ts"
],
"types": "src/require.ts",
"license": "MIT",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/proxy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"lib"
],
"types": "./lib/index.ts",
"license": "MIT",
"workspaces": {
"nohoist": [
"devtools-protocol"
Expand Down
1 change: 1 addition & 0 deletions packages/reporter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,6 @@
"webpack-cli": "^5.1.4"
},
"files": [],
"license": "MIT",
"nx": {}
}
4 changes: 4 additions & 0 deletions packages/resolve-dist/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
**/tsconfig.json
**/tsconfig.base.json
**/tsconfig.esm.json
**/tsconfig.cjs.json
cjs/index.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unrelated ESLint Changes in License PR

The .eslintignore changes in this commit are unrelated to the PR's stated purpose of adding license fields to package.json files. These additions appear to be accidentally included or are not documented.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah, I have no idea why this failed in this PR's eslint check honestly, but it was trying to eslint the cjs/index.js file oddly.

1 change: 1 addition & 0 deletions packages/resolve-dist/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"esm/*"
],
"types": "./cjs/index.d.ts",
"license": "MIT",
"module": "esm/index.js",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/rewriter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"lib"
],
"types": "./lib/index.ts",
"license": "MIT",
"workspaces": {
"nohoist": [
"parse5-html-rewriting-stream",
Expand Down
1 change: 1 addition & 0 deletions packages/root/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"rollup": "^4.52.0",
"typescript": "^5.6.3"
},
"license": "MIT",
"module": "index.mjs",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/runner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"files": [
"dist"
],
"license": "MIT",
"nx": {
"implicitDependencies": [
"@packages/driver",
Expand Down
1 change: 1 addition & 0 deletions packages/scaffold-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"esm/*"
],
"types": "cjs/index.d.ts",
"license": "MIT",
"module": "esm/index.js",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,5 +243,6 @@
"fsevents": "^2",
"registry-js": "1.15.0"
},
"license": "MIT",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/socket/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"esm/",
"patches"
],
"license": "MIT",
"module": "esm/node/index.js",
"workspaces": {
"nohoist": [
Expand Down
1 change: 1 addition & 0 deletions packages/stderr-filtering/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"dist"
],
"types": "dist/index.d.ts",
"license": "MIT",
"lint-staged": {
"**/*.{js,jsx,ts,tsx,json,eslintrc,vue}": "eslint --fix"
}
Expand Down
1 change: 1 addition & 0 deletions packages/telemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"browser"
],
"types": "cjs/node.d.ts",
"license": "MIT",
"module": "esm/node.js",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@
"register.js",
"registerDir.js"
],
"license": "MIT",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"esm/*"
],
"types": "cjs/index.d.ts",
"license": "MIT",
"module": "esm/index.js",
"workspaces": {
"nohoist": [
Expand Down
1 change: 1 addition & 0 deletions packages/v8-snapshot-require/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@
"src/snapshot-require.ts"
],
"types": "src/snapshot-require.ts",
"license": "MIT",
"nx": {}
}
1 change: 1 addition & 0 deletions packages/web-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,6 @@
"webpack-cli": "^5.1.4",
"webpack-livereload-plugin": "3.0.2"
},
"license": "MIT",
"nx": {}
}
Loading