refactor: modernizes visibility tests #32833
Open
+1,057
−1,249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
refactor/visibility-tests
|
| Run status |
|
| Run duration | 16m 10s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
11
|
Skipped
|
0
|
Passing
|
636
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
0%
|
|
|---|---|
|
Untested elements
|
4
|
|
Tested elements
|
0
|
Accessibility
100%
|
|
|---|---|
|
Failed rules
|
0 critical
0 serious
0 moderate
0 minor
|
|
Failed elements
|
0
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| expect(this.$tableVisCollapse.find('tr.collapse')).to.be.hidden | ||
| expect(this.$tableVisCollapse.find('tr.collapse')).to.not.be.visible | ||
| describe('html is display none', () => { |
There was a problem hiding this comment.
Did we remove the test where html/body are not display none?
There was a problem hiding this comment.
added back in 4573e14
ryanthemanuel
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In preparation for testing visibility algorithm modifications, this refactors the
visibility.cy.tsspec. It now uses static html fixtures, and a declarative testing style that makes it easier to determine what should and should not be visible.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Rewrites DOM visibility tests to use static HTML fixtures with declarative expectations and shared helpers, expanding coverage across CSS, forms, overflow, positioning, transforms, and reason messages.
packages/driver/cypress/e2e/dom/visibility.cy.ts:assertVisibilityForEl,prepareFixtureSection,assertVisibilityForSectionsand groups tests into scenario suites.cy-expect/cy-legacy-expect.html/bodyoverrides and updates#getReasonIsHiddenassertions to read from fixtures.packages/driver/cypress/fixtures/visibility/:basic-css-properties.html,form-elements.html,overflow.html,positioning.html,transforms.html,empty.html,table-visibility.html.style.css(section visibility and highlighting) andux.js(in-page nav/section activation).Written by Cursor Bugbot for commit 4573e14. This will update automatically on new commits. Configure here.