Skip to content

Conversation

@AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 28, 2025

  • Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks


Note

Migrates server utilities and file server to TypeScript, updates random/env APIs and imports, integrates typed file server/HTTPS proxy, and adjusts tests accordingly.

  • TypeScript Migration:
    • Convert file_server, util/env, and util/terminal-size from JS to TS; add typings for FileServer and HTTPS proxy Server.
    • Refactor util/file to TS File class with typed methods and noopFile; update call sites (cache.ts, saved_state.ts, tests) to import { File as FileUtil }.
  • Import/API Alignment:
    • Replace default env import with * as env; in util/resolve.js use process.env directly.
    • Switch random helper to named id export and update usages across server (modes, run, cloud/auth, etc.).
    • In https-proxy/lib/index.ts, re-export type { Server }.
  • Server Integration:
    • Replace JS file server with TS implementation; update server-base.ts to import * as fileServer, type cast _httpsProxy and _fileServer, and pass fileServerFolder as string.
    • Minor header/typing tweaks (e.g., set x-cypress-file-server-error to 'true', add @ts-expect-error notes).
  • Behavioral/Utility Tweaks:
    • Ensure numeric interval in print-run.beginUploadActivityOutput via Number(UPLOAD_ACTIVITY_INTERVAL).
  • Tests:
    • Update unit tests to TS imports and new File export; adjust random ID tests to use randomId.

Written by Cursor Bugbot for commit 18c1405. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

@cypress
Copy link

cypress bot commented Oct 28, 2025

cypress    Run #66908

Run Properties:  status check failed Failed #66908  •  git commit 18c1405b46: convert a handful of files to TypeScript
Project cypress
Branch Review chore/refactor_server_p2
Run status status check failed Failed #66908
Run duration 43m 19s
Commit git commit 18c1405b46: convert a handful of files to TypeScript
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 10
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26625
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  97.98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/commands/files.cy.js • 1 failed test • 5x-driver-firefox

View Output

Test Artifacts
src/cy/commands/files > #readFile > retries to read when ENOENT
    </td>
  </tr></table>
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > errors > throws when waiting for 2nd response to route Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay

The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -0,0 +1,88 @@
// TODO: move this to packages/core-file-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment is relevant? This doesn't event exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants