feat: considerations for elements within ShadowRoot #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tbiethman
changed the title
mike-plummer
approved these changes
Apr 3, 2025
Comment on lines
+11
to
+15
| // Using getRootNode here to scope checks to any parent | ||
| // ShadowRoot. getRootNode will otherwise return the | ||
| // document associated to the elements page/frame (like | ||
| // the ownerDocument property would). | ||
| var elems = el.getRootNode().querySelectorAll(selector); |
tbiethman
changed the title
mabela416
approved these changes
Apr 3, 2025
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a few cases here where the APIs in use do not account for the elements being contained in a Shadow DOM.