Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of updates and improvements #3

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

selfsimilar
Copy link

  • Update ThreeJS to most recent version which required removing sRGBEncoding import. I think this is explained here.
  • Improve model detection to use file's MIMEtype when file-extension lookup fails.
  • Fix help text hiding on initial render.

deprecates explicit use of sRGBEcoding.
A src URL will not always be guaranteed to match
the file name and end with the file extension. If
there is no file-extension match, we can check the
mimetype of the file to determine the model type.
@cyrilpic
Copy link
Owner

cyrilpic commented Sep 9, 2024

@selfsimilar Is this pull request complete? Any issues?

@selfsimilar
Copy link
Author

I've been using these changes for the last few months without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants