Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for collate #442

Open
d33bs opened this issue Sep 16, 2024 · 1 comment
Open

Increase test coverage for collate #442

d33bs opened this issue Sep 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@d33bs
Copy link
Member

d33bs commented Sep 16, 2024

In working through #437 via #439 I noticed that collate has collate has much lower test coverage than other components within pycytominer. We could increase this coverage with some further tests, possibly while also addressing #315 and #394 .

@d33bs d33bs added the enhancement New feature or request label Sep 16, 2024
@gwaybio
Copy link
Member

gwaybio commented Sep 16, 2024

Yes, we could, in theory increase coverage. See #160 (review) for our initial discussion of code coverage for collate

Given the march toward 2.0, which won't support collate, I'm not sure if it's a wise time investment to increase coverage at this time. Also, there have been no complaints about this functionality not working to my knowledge.

Also, we deprecated cytominer-database last week. https://github.com/cytomining/cytominer-database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants