Skip to content
This repository was archived by the owner on Nov 7, 2018. It is now read-only.

Conversation

odorovic
Copy link

@odorovic odorovic commented Aug 2, 2015

Although d3 itself exists as a node.js package, the plugins are usable
only from the browser.

--Make sure sankey plugin can be loaded through node.js
--Put in basic package structure and plugin loadin mechanism for node

Although d3 itself exists as a node.js package, the plugins are usable
only from the browser.

--Make sure sankey plugin can be loaded through node.js
--Put in basic package structure and plugin loadin mechanism for node
@odorovic
Copy link
Author

odorovic commented Aug 2, 2015

Hi,

I hope this is an acceptable change, as it's my first one for the project. Formatting of sankey.js is a bit off, as I didn't want to create a huge diff when wrapping the code in module boilerplate.

@mbostock
Copy link
Member

mbostock commented Aug 4, 2015

My plan is to create a separate d3-sankey module as part of the new D3 4.0 restructuring. See d3/d3-format for an example of another D3 module.

@odorovic
Copy link
Author

odorovic commented Aug 4, 2015

That's great progress, and I'm aware of the effort. Can I somehow help amend this pull request to accommodate for that plan, or should I just stay put and wait for the restructuring?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants