Skip to content

Conversation

@ppth0608
Copy link
Contributor

Summary

This PR removes the deprecated layout mode system and component size storage
functionality from KarrotListKit. These features were no longer being used and
added unnecessary complexity to the codebase.

Changes

  • Removed layoutMode property from Component protocol and AnyComponent
    • Deleted ContentLayoutMode enum entirely
    • Cleaned up related test code
  • Removed sizeStorage functionality
    • Deleted ComponentSizeStorage class
    • Removed size storage integration from CollectionViewAdapter and CollectionViewLayoutAdaptable
    • Cleaned up size storage usage in collection view cells and reusable views
  • Removed unused section layout implementations
    • Deleted DefaultCompositionalLayoutSectionFactory, HorizontalLayout,
      VerticalGridLayout, and VerticalLayout classes
    • Simplified CompositionalLayoutSectionFactory by removing layout-specific
      logic
    • Updated Section to remove layout-related properties
  • Updated documentation and sample app
    • Updated README to reflect the removal of layout mode
    • Simplified sample app code that was using the removed features

Impact

This is a breaking change that removes previously deprecated APIs. Projects
using layoutMode, sizeStorage, or the removed layout classes will need to
migrate to alternative approaches.

Testing

  • All existing tests have been updated
  • Removed tests specific to the deleted functionality
  • Sample app has been tested and works correctly without these features

@ppth0608
Copy link
Contributor Author

@jaxtynSong 이 작업하신 내용이에요. PR만 대신 올렸어요!


final class CollectionViewMock: UICollectionView {

private var windowView = UIWindow()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3; 주입되지 않는 속성이라 private let으로 작성해도 될 것 같은데 어떨까요?

Suggested change
private var windowView = UIWindow()
private let _window = UIWindow()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

019b10a에서 반영했어요~

Copy link
Contributor

@stleamist stleamist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants