-
Notifications
You must be signed in to change notification settings - Fork 7
[Breaking] Remove Layout Mode and Size Storage #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jaxtynSong 이 작업하신 내용이에요. PR만 대신 올렸어요! |
|
|
||
| final class CollectionViewMock: UICollectionView { | ||
|
|
||
| private var windowView = UIWindow() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3; 주입되지 않는 속성이라 private let으로 작성해도 될 것 같은데 어떨까요?
| private var windowView = UIWindow() | |
| private let _window = UIWindow() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
019b10a에서 반영했어요~
stleamist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻👍🏻
Summary
This PR removes the deprecated layout mode system and component size storage
functionality from
KarrotListKit. These features were no longer being used andadded unnecessary complexity to the codebase.
Changes
Componentprotocol andAnyComponentContentLayoutModeenum entirelysizeStoragefunctionalityComponentSizeStorageclassCollectionViewAdapterandCollectionViewLayoutAdaptableDefaultCompositionalLayoutSectionFactory,HorizontalLayout,VerticalGridLayout, andVerticalLayoutclassesCompositionalLayoutSectionFactoryby removing layout-specificlogic
Impact
This is a breaking change that removes previously deprecated APIs. Projects
using layoutMode, sizeStorage, or the removed layout classes will need to
migrate to alternative approaches.
Testing