Require python >= 3.6 in setup.py and include tests with release #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
costrouc
added a commit
to costrouc/nixpkgs
that referenced
this pull request
Feb 7, 2019
tests will be included with the next release dabeaz/sly#25 this is why I have not disabled tests (currently they pass with 0 tests run).
vdemeester
pushed a commit
to vdemeester/nixpkgs
that referenced
this pull request
Feb 7, 2019
tests will be included with the next release dabeaz/sly#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pynow requires that it is installed on python 3.6 or greater.Also wanted to include sly in the nix package manager one thing we try to do is include tests with each package so that it is easy to test.