Feat: Add --rust-module-name to specify a module name #5747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler now can write to a concrete syntax tree
MikaelMayer
changed the title
MikaelMayer
commented
Sep 5, 2024
robin-aws
requested changes
Sep 12, 2024
| @@ -1675,7 +1675,9 @@ module {:extern "DCOMP"} DafnyToRustCompiler { | |||
| ASSIGNED_PREFIX + "_" + rustName | |||
| } | |||
|
|
|||
| datatype ObjectType = RawPointers | RcMut | |||
| datatype PointerType = Raw | RcMut | |||
| datatype CharType = UTF16 | Unicode | |||
There was a problem hiding this comment.
nit: "Unicode" is too vague to be much help, consider UTF32 instead
There was a problem hiding this comment.
Would it be too much to ask for a test case of a manually-written Rust crate, with manually-written Rust code and a Cargo.toml, where you use dafny translate to add additional code under a given --rust-module-name, and use cargo test to verify that all works?
That's the killer application of this option by itself: not forcing the output of Dafny to be the top level namespace, and enabling incremental adoption of Dafny into an existing Rust project!
There was a problem hiding this comment.
Test written. I removed the other one since it was obsolete
robin-aws
reviewed
Sep 16, 2024
robin-aws
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #5641
This PR adds
--rust-module-nameso that all absolute paths from crate insert the given module name after "crate" if the option is provided.Description
I could have made it a boolean option since it should match the name of the generated file, but by consistency with other backends, I made it so that the option accepts any string. Let me know if you think a boolean would be better.
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.