Dev multi asset ops handler error #29358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unitest for case with failed output_handler during op execution.
- Add optional argument for skip_failed_execution for op. - Add property handler and setter for skip_failed_execution in OpDefinition. - Add skip_failed_execution argument for multiasset to set Op argument.
…manager output handle. - Add additional algorithm to handle exception during the for-loop to not interrupt the execution process. - Use op skip_failed_execution flag to determine whether loop should be interrupted or not. - Log all error catch during the loop to log and raise final error message to be catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
When a single output of a multi asset fails during HANDLE_OUTPUT, the whole multi asset is aborted.
This PR try to solve that problem.
See #27943 for more details and example.
How I Tested These Changes
I create new unit test in test_materilize.py to simulate the situation where old method failed. Then new algorithm is implemented which can then be enabled with additional flag
skip_failed_execution.Example situation from #27943 is also recreated to test new feature in situation.
Changelog