Smoother keyboard turning. #2613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way always annoying how the ship keeps turning after letting go of the turn key. I don't think the current behavior is preferred, if it is, I think a new turn-by key should be added. I think this is the easiest fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #2611. This change is largely purposed to fix an issue also addressed in #2412, but I don't think that fit or discussion excludes this change.
The x5 that was done for turning seems very excessive, even when maneuvering at 300% in Engineering x1 is, I think, rather enough. With the target heading indicator added with #2611, the x1 also looks a bit smoother (not jumping the target heading indicator ahead).
I personally think this PR would not be a bad adjustment regardless of the conclusions from #2412.