Implement theme inheritance #2668
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional inherit keyword to the [base] section of themes. When defined with one or more theme names in a comma-separated list, all style properties not defined in the theme are inherited from the specified parent themes. All themes inherit from the default theme, which EE already requires.
Owner
|
This is a very good idea! I am wondering on the implementation. Wouldn't the code become a lot simpler if you merge at the |
Contributor
Author
|
I was trying to avoid traversing nested maps, especially at onDraw, but maybe in this case nested maps might not be an issue if I only do it when loading/processing the theme. |
Flatten themes on load into a temporary nested map and refactor base style inheritance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional
inheritkeyword to the[base]section of themes. When defined with one or more theme names in a comma-separated list, all style properties not defined in the theme are inherited from the specified parent themes.All themes inherit from the
defaulttheme, which EE already requires.Also adds an example inherited theme,
default-bebas, which overrides fonts with the BebasNeue font already in the repository.