chore: remove analyzer #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ldez Sorry for slow response! Could you help resolve conflicts then we can make it land? |
|
@daixiang0 In fact, the analyzer can be removed completely, we don't use it inside golangci-lint. Are you OK with me removing the analyzer? |
ldez
force-pushed
the
fix/analyzer
branch
9 times, most recently
from
181f0da to
4a1c415
Compare
|
@ldez sure. BTW, now how gci work inside golangci-lint? Is there anything to be done? |
|
Please sign commits as well :) |
Signed-off-by: Fernandez Ludovic <[email protected]>
Signed-off-by: Fernandez Ludovic <[email protected]>
Signed-off-by: Fernandez Ludovic <[email protected]>
Signed-off-by: Fernandez Ludovic <[email protected]>
Signed-off-by: Fernandez Ludovic <[email protected]>
Signed-off-by: Fernandez Ludovic <[email protected]>
Signed-off-by: Fernandez Ludovic <[email protected]>
|
|
|
Cool! @ldez thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analyzer is not used anymore.