Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix reflection warning on javax.xml.parsers.SAXParser #650

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

raszi
Copy link
Contributor

@raszi raszi commented Aug 17, 2024

Fixes the reflection warning that was introduced with #630.

There are only two different types that the library can pass to the javax.xml.parsers.SAXParser. It is either String or InputStream.

Unfortunately, I could not find a better way to fix the reflection warning just by refactoring the code a bit and have two explicit calls on the javax.xml.parsers.SAXParser/parse methods:

Copy link
Owner

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dakrone dakrone merged commit a9262a6 into dakrone:3.x Aug 19, 2024
0 of 15 checks passed
@raszi raszi deleted the fix/reflection-warning branch August 19, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants