chore: fix reflection warning on javax.xml.parsers.SAXParser#650
Merged
dakrone merged 1 commit intodakrone:3.xfrom Aug 19, 2024
Merged
chore: fix reflection warning on javax.xml.parsers.SAXParser#650dakrone merged 1 commit intodakrone:3.xfrom
dakrone merged 1 commit intodakrone:3.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the reflection warning that was introduced with #630.
There are only two different types that the library can pass to the
javax.xml.parsers.SAXParser. It is eitherStringorInputStream.Unfortunately, I could not find a better way to fix the reflection warning just by refactoring the code a bit and have two explicit calls on the
javax.xml.parsers.SAXParser/parsemethods: