fix: rebuild timeline filter when contact list changes #1226
+138
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add infrastructure to track when a contact list filter was built, enabling detection of stale filters after follow/unfollow actions. Changes: - Add `contact_list_timestamp` field to FilterStates - Add `invalidate()` method to reset filter states for rebuild This is preparatory work for fixing damus-io#1225 where unfollowed accounts still appear in the feed because the timeline filter is not rebuilt when the contact list changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: e <e@*.lan> Signed-off-by: alltheseas
Add methods to properly reset timeline state when filters need to be rebuilt (e.g., after follow/unfollow actions). Changes: - TimelineSub::reset(): Unsubscribes from ndb and relay pool before resetting state. Preserves depender count for reference counting. - TimelineTab::reset(): Clears cached notes and resets virtual list. - Timeline::reset_views(): Resets all view tabs. These methods ensure no subscription leaks when rebuilding timelines, and that stale notes from unfollowed accounts are cleared. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: e <e@*.lan> Signed-off-by: alltheseas
Closes damus-io#1225 Fixes damus-io#1225 - unfollowed accounts still showing up in feed. The root cause was that timeline filters were built once from the contact list and never updated when users followed/unfollowed accounts. Changes: - Add `contact_list_needs_rebuild()` helper to detect stale filters - Modify `is_timeline_ready()` to check for contact list changes and trigger filter rebuild when detected - Store contact list timestamp when filter is built - Add `#[profiling::function]` attribute for performance monitoring The rebuild flow: 1. Detect timestamp mismatch between filter and current contact list 2. Invalidate filter states (reset to NeedsRemote) 3. Clear cached notes from views 4. Reset subscription (properly unsubscribing first) 5. Fall through to normal filter build path Code follows nevernesting pattern with early returns and extracted helper function for readability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: e <e@*.lan> Signed-off-by: alltheseas
alltheseas
force-pushed
the
fix/contact-list-rebuild
branch
from
2246b53 to
4b9e83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1225 - unfollowed accounts still showing up in feed.
The root cause was that timeline filters were built once from the contact list and never updated when users followed/unfollowed accounts. The profile page correctly showed the updated follow state because it queries the live
ContactState, but the timeline kept using the stale filter.Changes
Commit 1: filter: add contact_list_timestamp tracking to FilterStates
contact_list_timestampfield to track when filter was builtinvalidate()method to reset filter states for rebuildCommit 2: timeline: add reset methods for subscription and view cleanup
TimelineSub::reset(): Properly unsubscribes from ndb/relay pool before resettingTimelineTab::reset(): Clears cached notes and resets virtual listTimeline::reset_views(): Resets all view tabsCommit 3: timeline: rebuild filter when contact list changes
contact_list_needs_rebuild()helper to detect stale filtersis_timeline_ready()to check for contact list changes#[profiling::function]for performance monitoringTest plan
🤖 Generated with Claude Code