nav: fix noteview requiring two clicks to go back #1231
+194
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The back button chevron was only 8x15 pixels, well below the WCAG 2.1 minimum of 44x44 CSS pixels for touch targets. This made it easy to miss clicks, especially on touch devices. - Add MIN_TOUCH_SIZE constant (44.0) for WCAG compliance - Expand back button hitbox to meet minimum size - Extend hitbox to left edge for easier targeting - Add regression tests for hitbox size requirements Part of fix for GitHub issue damus-io#1230. Signed-off-by: alltheseas 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The header's window drag sensing was capturing clicks before the back button could process them (visible as the 4-way drag cursor appearing on first click). - Render title bar first so back button gets click priority - Gate drag detection on pointer NOT being over back button hitbox - Skip drag if pointer position is unknown (avoids capturing clicks) - Disable window drag entirely on Android/iOS (not applicable) Part of fix for GitHub issue damus-io#1230. Signed-off-by: alltheseas 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
On Linux and Android with event-driven rendering, no repaint was requested after processing back actions, causing the return animation to stall until another input event occurred. - Request repaint when returning state transitions from false to true (critical for Android where first frame won't emit NavAction::Returning) - Request continuous repaints during NavAction::Returning for stack nav - Request continuous repaints during NavAction::Returning for sheet/popup Closes damus-io#1230 Signed-off-by: alltheseas 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
alltheseas
force-pushed
the
fix-noteview-two-clicks
branch
from
f1c69e4 to
1ce0249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1230
Test plan
🤖 Generated with Claude Code