Skip to content

Replaceable event notifications & subscribed notifications for non-mentions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

v0l
Copy link

@v0l v0l commented May 22, 2025

Made quite a few changes here..

  1. Changed notification settings to use a comma separated list of kind numbers instead of boolean flags.
    This is still backwards compatible as the API calls are the same, you can use the boolean flags to set the kind number.
  2. Added a new concept called notify_keys which allows users to subscribe to notifications on when another pubkey posts an event (Live Stream / Article etc)
    This required a change to the notifications table to create a distinct key for replaceable events so that we only see a notification once (When its first published)

This PR includes all the changes i also made for FCM so it depends on #19

Direct compare: https://github.com/damus-io/notepush/compare/cbe9a65ccfaed67bb8cc6d9816cff04eeda2cb7c..44aade5de70219af238086df1783094bf1db3b2a

@jb55
Copy link
Contributor

jb55 commented Jun 4, 2025

oops just saw this! reviewing

@v0l
Copy link
Author

v0l commented Jun 5, 2025

Feel free not to merge this, i ended up making a bunch of changes that you might not want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants