-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint 8.x #108
Conversation
ad56d91
to
61027e9
Compare
@MichaelDeBoey Thanks for the PR. Need any help? (I know it's still in Draft, but couldn't help taking a look.) |
@benkimpel I think I'm mostly waiting on the devDeps to support ESLint 8.x now 🤔 |
Great! 👍 |
2c9ba5a
to
b05d7ea
Compare
bf5184b
to
f73e86b
Compare
f73e86b
to
5ddf7dd
Compare
Hey @MichaelDeBoey, you have some linting errors |
@dangreenisrael Should I just ignore 18:19 error 'StatementType' is already declared in the upper scope on line 18 column 19 no-shadow
40:19 error 'PaddingType' is already declared in the upper scope on line 40 column 19 no-shadow |
I'm cool with that. Will you just add a comment in the code explaining why we are making an exception to the rule? |
5ddf7dd
to
da5c29d
Compare
da5c29d
to
d43ab9e
Compare
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
d43ab9e
to
5846912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you! 🙏
@MichaelDeBoey I want to give @dangreenisrael a chance to review, but this will probably merge tomorrow. |
I'm going to take Dan's comment as tacit approval for a merge. He'll have to trigger the release to npm, though. |
@dangreenisrael Can you please trigger the release? |
|
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
@typescript-eslint/eslint-plugin
(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)meta.docs.category
from rules typescript-eslint/typescript-eslint#3800PrivateIdentifier
typescript-eslint/typescript-eslint#3808v5.0.0
@typescript-eslint/parser
(Support for ESLint v8 typescript-eslint/typescript-eslint#3738)meta.docs.category
from rules typescript-eslint/typescript-eslint#3800PrivateIdentifier
typescript-eslint/typescript-eslint#3808v5.0.0
eslint-config-airbnb-base
(eslint v8 support airbnb/javascript#2478)v15.0.0
eslint-config-prettier
(Support ESLint 8.x prettier/eslint-config-prettier#200)Releaseeslint-plugin-import
(Support ESLint 8.x import-js/eslint-plugin-import#2211)v2.25.0
eslint-plugin-jest
(Support ESLint 8.x jest-community/eslint-plugin-jest#881)hasSuggestion
for ESLint v8 jest-community/eslint-plugin-jest#898hasSuggestions
rather thanhasSuggestion
jest-community/eslint-plugin-jest#899eslint@8
jest-community/eslint-plugin-jest#940@typescript-eslint/experimental-utils
to v5 jest-community/eslint-plugin-jest#941@typescript-eslint/eslint-plugin@5
jest-community/eslint-plugin-jest#942v24.4.1
v24.4.2
v25.0.0
v25.0.4
v25.0.5
v25.1.0
eslint-plugin-prettier
(Support ESLint 8.x prettier/eslint-plugin-prettier#427)ReleaseBREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
Closes #107