Skip to content

Fix the month reported in the logs' timestamp #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2023

Conversation

danielealbano
Copy link
Owner

This PR fixes the month reported in the logs' timestamp incrementing the month value returned by gmtime by 1, as gmtime returns the month from 0 to 11.

@danielealbano danielealbano added the bug Something isn't working label Jun 11, 2023
@danielealbano danielealbano added this to the v0.5 milestone Jun 11, 2023
@danielealbano danielealbano self-assigned this Jun 11, 2023
@danielealbano danielealbano enabled auto-merge (squash) June 11, 2023 14:32
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (fee0e7a) 76.73% compared to head (3a185a2) 76.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   76.73%   76.66%   -0.07%     
==========================================
  Files         199      199              
  Lines       13652    13652              
==========================================
- Hits        10475    10465      -10     
- Misses       3177     3187      +10     
Flag Coverage Δ
unittests 76.66% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/log/log.c 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielealbano danielealbano merged commit 2b3199e into main Jun 11, 2023
@danielealbano danielealbano deleted the bug/fix-logs-timestamp branch June 11, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant