Draft: Added a buffered reader for dtx connections #435
Conversation
diegoperini
changed the title
diegoperini
force-pushed
the
dp-buffered-dtx-reader
branch
from
2605fd1
to
05cd394
Compare
| @@ -31,11 +34,12 @@ type DeviceConnectionInterface interface { | |||
| type DeviceConnection struct { | |||
| c net.Conn | |||
| unencryptedConn net.Conn | |||
| bufferedReader io.Reader | |||
There was a problem hiding this comment.
I don't think that's the right place to add a buffered reader. We have two connections to the device already in this struct. If we add buffering now to one of them, the buffer may hold more data than expected and switching between those sessions could break (I think this is mainly happening on older iOS versions)
If you want to add buffering to the DTX connection as the title says, it would be safer to do so in the DTX connection itself as nothing about the connection would change at that point anymore.
There was a problem hiding this comment.
I think I understand.
That would mean I may have to define a new type that implements net.Conn, wraps a real net.Conn and uses a buffered reader internally for the Read() operations. The rest of the operations would be delegated to the wrapped, original net.Conn instance.
MOSTY IMPORTANTLY, this should happen BEFORE we construct a DeviceConnection object.
Correct?
|
Closing this one. Alternative solution here: https://github.com/danielpaulus/go-ios/pull/438/files |
No description provided.