Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put XCTest parameters into a config struct #507

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

dmissmann
Copy link
Collaborator

This is a follow up of #506
I noticed there that we already quite a few arguments that we pass around in the XCTest methods. To clean that up I put them into a struct. (also, with #464 support for unit tests was added and the functions were still called XCUITest)

this value has changed with iOS 17. While this did not cause problems in most
cases, UI interruption handlers were broken because of that. They simply stopped
firing with that value pointing to the old path
@dmissmann dmissmann marked this pull request as ready for review October 29, 2024 13:21
Copy link
Owner

@danielpaulus danielpaulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

@danielpaulus
Copy link
Owner

@dmissmann can you resolve the conflicts?

@dmissmann dmissmann merged commit 4cd5d9f into main Nov 8, 2024
5 checks passed
@dmissmann dmissmann deleted the dm-xctest-config-struct branch November 8, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants