Skip to content

Conversation

@peter-sk
Copy link
Member

No description provided.

@peter-sk peter-sk requested review from KennethEnevoldsen and saattrupdan and removed request for KennethEnevoldsen May 21, 2025 08:09
@peter-sk peter-sk requested review from JacobBITLABS and rlrs May 21, 2025 08:34
peter-sk and others added 3 commits May 21, 2025 11:37
Co-authored-by: Dan Saattrup Nielsen <[email protected]>
Co-authored-by: Dan Saattrup Nielsen <[email protected]>
@peter-sk peter-sk requested a review from saattrupdan May 21, 2025 09:39
@peter-sk peter-sk requested a review from saattrupdan May 21, 2025 13:01
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lot to add here.

A minor thing is that the requirement could be moved to pyproject.toml

Copy link
Collaborator

@saattrupdan saattrupdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also second Kenneth's comment regarding moving all dependencies to pyproject.toml, insofar that it's possible.

@peter-sk peter-sk merged commit c82f4ec into main May 21, 2025
1 check passed
@peter-sk peter-sk deleted the cleaning-up branch May 21, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants