Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide suspended enrollments from roster by default #667

Open
wants to merge 1 commit into
base: MOODLE_311_STABLE
Choose a base branch
from

Conversation

pennedav
Copy link

@pennedav pennedav commented Feb 9, 2023

Implements a simple enrolment status filtering mechanism to hide suspended enrollments from the roster by default. Implements a simple UI dropdown to enable normal behavior.

Very likely should be enhanced via some sort of admin setting to adjust default behavior if desired.

This patch does not provide any Behat tests and applies only to the 3.11 branch. Merging to Moodle 4 branch will require more work.

The lack of this functionality was causing a lot of frustration for instructors at my institution since we suspend enrollments instead of unenrolling (for various reasons) so this is a quick-and-dirty implementation to work around this.

@pennedav pennedav changed the base branch from MOODLE_402_STABLE to MOODLE_311_STABLE February 9, 2023 20:37
@pennedav pennedav marked this pull request as ready for review February 9, 2023 20:40
@danmarsden
Copy link
Owner

Thanks for the PR - this does sound like it would be useful for others as well - I'd prefer to have this covered by behat tests before I merge this in too - any chance you might be able to write something to cover the change and test it?

@pennedav
Copy link
Author

I'll certainly try. I've not used Behat before so it'll take me a bit to do probably. My time is rather limited at the moment. I was reviewing the existing tests and it looks like this scenario would be a good starting point to copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants