Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load teacher names in dialogue creation with large number of users and groups in a course #137

Merged

Conversation

sumaiyamannan
Copy link
Contributor

Hi,

Improve the performance of the user selector on the create dialogue page when used in courses with large numbers of users in groups – This will resolve the issue experienced where Teacher names are not loading within the selector in large groups.

To replicate the issue have the below setup:

  • Create a Moodle 4.1 instance has a large number of users and groups
  • Create 25,000 users,
  • Create 5 courses,
  • Add the Dialogue activity to at least one course,
  • Create 5 groups in each of the 5 courses,
  • Enrol 5000 users with the Student role on to each of the 5 courses,
  • Assign 1000 users to each group,
  • Enrol 5 additional users with the Teacher role on to each of the 5 courses,
  • Assign 1 Teacher to each of the 5 groups
  • Remove mod/dialogue:receive capability from the 'student' role

Log in as a Student who is enrolled on the same course which has the Dialogue Activity added,

  • Access the course and go to the Dialogue activity,
  • Click on the 'Create' link,
  • Locate the 'Open with' search field and click the search arrow.

Expected behaviour: The search should return the name of the Teacher who is in the same group as the logged on Student.
Actual behaviour: No results are returned.

Regards,
Sumaiya

@danmarsden danmarsden merged commit a9cb77e into danmarsden:MOODLE_401_STABLE Sep 30, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants