Skip to content

Adds functionality to disable UPnP on package-by-package basis #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

3alpha
Copy link
Member

@3alpha 3alpha commented Apr 7, 2025

Context

Now, there is no way to expose ports just locally on package-by-package basis. If there are ports defined in compose Dappmanager is always trying to make upnp call to router to do port forwarding. There is possibility to disable upnp all together, but that is not good enough.

Approach

When parsing what ports to open Dappmanager goes through blacklist of ports defined in manifest and skips them if found

Test instructions

Install this Dappmanager and package which implements this feature (e.g. Pi hole).

  • Make sure that logs say that ports are skipped
  • Check on your router that ports are not exposed

@3alpha 3alpha requested a review from a team as a code owner April 7, 2025 11:24
Copy link

github-actions bot commented Apr 7, 2025

Copy link

github-actions bot commented Apr 7, 2025

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: ec877ca

This is a development version and should only be installed for testing purposes.

  1. Package dappmanager.dnp.dappnode.eth

Install link

Hash: /ipfs/QmVawuVVYCCdbpJknvttDEHFS5tw1WF5p5RRk2YghaBdd3

(by dappnodebot/build-action)

@github-actions github-actions bot temporarily deployed to commit April 14, 2025 07:55 Inactive
@github-actions github-actions bot temporarily deployed to commit April 15, 2025 11:46 Inactive
@github-actions github-actions bot temporarily deployed to commit April 15, 2025 12:15 Inactive
@github-actions github-actions bot temporarily deployed to commit April 21, 2025 11:34 Inactive
@github-actions github-actions bot temporarily deployed to commit April 23, 2025 15:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants