Adds functionality to disable UPnP on package-by-package basis #2137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now, there is no way to expose ports just locally on package-by-package basis. If there are ports defined in compose Dappmanager is always trying to make upnp call to router to do port forwarding. There is possibility to disable upnp all together, but that is not good enough.
Approach
When parsing what ports to open Dappmanager goes through blacklist of ports defined in manifest and skips them if found
Test instructions
Install this Dappmanager and package which implements this feature (e.g. Pi hole).