[dotnet-client] Add dist lock examples #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Hunter <[email protected]>
11 tasks
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 170 170
Lines 5652 5652
Branches 600 600
=======================================
Hits 3815 3815
Misses 1697 1697
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. |
halspang
reviewed
May 19, 2023
Comment on lines
217
to
218
| string DAPR_LOCK_NAME = "lockstore"; | ||
| string fileName = "my_file_name"; |
There was a problem hiding this comment.
We should be consistent in our variable naming scheme.
There was a problem hiding this comment.
@halspang let me know if I addressed this right
Comment on lines
249
to
250
| string DAPR_LOCK_NAME = "lockstore"; | ||
| var client = new DaprClientBuilder().Build(); |
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
halspang
approved these changes
May 22, 2023
onionhammer
pushed a commit
to onionhammer/dotnet-sdk
that referenced
this pull request
May 30, 2023
* add dist lock to dotnet client doc Signed-off-by: Hannah Hunter <[email protected]> * attempt at naming scheme 1 Signed-off-by: Hannah Hunter <[email protected]> * yikes put it back Signed-off-by: Hannah Hunter <[email protected]> * attempt 2 Signed-off-by: Hannah Hunter <[email protected]> * attempt 3 Signed-off-by: Hannah Hunter <[email protected]> --------- Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: Erik O'Leary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing dist lock examples to the dotnet client doc
Issue reference
PR will help close: dapr/docs#2770
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: