-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the warn log issue caused by not setting the dapr.client.grpcPort… #1289
Conversation
@seal90 thanks a lot for your contribution! I have a few asks:
Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Errors are related to checkstyle. |
… variable Signed-off-by: seal90 <[email protected]>
Okay I got it.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
============================================
- Coverage 76.91% 75.47% -1.44%
- Complexity 1592 1616 +24
============================================
Files 145 193 +48
Lines 4843 5101 +258
Branches 562 555 -7
============================================
+ Hits 3725 3850 +125
- Misses 821 935 +114
- Partials 297 316 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… variable
Description
Please explain the changes you've made
Add null verification for io.dapr.spring.boot.autoconfigure.client.DaprClientAutoConfiguration#createPropertiesFromConnectionDetails
When using the grpc protocol without configuring dapr.client.grpcPort, the following warn information will be printed.This is because put("dapr.grpc.port", "null") in the above code causes DaprClientAutoConfiguration#daprWorkflowClient to use Property#get to parse the configuration and fail to handle the string "null"
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1292
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: