Loop drain on close #126
Merged
Loop drain on close #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update looper to drain the Enqueue loop in the event that an error has occurred when Enqueuing. Handle an error'd `Run` on `Close` by respecting the `closedCh` channel. Signed-off-by: joshvanl <[email protected]> Signed-off-by: Luis Rascao <[email protected]>
Signed-off-by: joshvanl <[email protected]> Signed-off-by: Luis Rascao <[email protected]>
lrascao
force-pushed
the
loop-drain-on-close
branch
from
f60e9f6 to
7c7973d
Compare
JoshVanL
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #124 to 1.15 release branch