Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-client] Add dist lock examples #567

Merged
merged 3 commits into from
May 24, 2023
Merged

Conversation

hhunter-ms
Copy link
Contributor

@hhunter-ms hhunter-ms commented May 19, 2023

Description

Added the missing dist lock example to the python client doc

Issue reference

PR will help close: dapr/docs#2770

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@hhunter-ms hhunter-ms requested review from a team as code owners May 19, 2023 15:31
@hhunter-ms
Copy link
Contributor Author

@berndverst definitely review the examples I've added - and if there's a bulk subscribe example floating around, let me know

@hhunter-ms hhunter-ms mentioned this pull request May 19, 2023
11 tasks
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #567 (c43edfa) into master (e27dac9) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head c43edfa differs from pull request most recent head 2e4a92b. Consider uploading reports for the commit 2e4a92b to get more accurate results

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   89.60%   89.59%   -0.02%     
==========================================
  Files          72       62      -10     
  Lines        3310     2978     -332     
==========================================
- Hits         2966     2668     -298     
+ Misses        344      310      -34     

see 12 files with indirect coverage changes

@hhunter-ms hhunter-ms changed the title [python-client] Add bulk publish and dist lock examples [python-client] Add dist lock examples May 19, 2023
@hhunter-ms
Copy link
Contributor Author

@berndverst removed bulk publish/subscribe until it's implemented.. thanks for your help!

@berndverst berndverst merged commit d2c2c50 into dapr:master May 24, 2023
elena-kolevska pushed a commit to elena-kolevska/python-sdk that referenced this pull request Sep 4, 2023
* add bulk publish and dist lock; fix typos

Signed-off-by: Hannah Hunter <[email protected]>

* remove bulk publish as not implemented yet

Signed-off-by: Hannah Hunter <[email protected]>

---------

Signed-off-by: Hannah Hunter <[email protected]>
Co-authored-by: Bernd Verst <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK documentation gaps
2 participants