Improve the error handling for HTTP client so consumers can trigger appropriate behavior

[passuied]

Description

Improve the error handling for HTTP client so consumers can trigger appropriate behavior

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #794

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation (n/a)

[elena-kolevska]

I feel like instead of modifying the genericDaprInternalError class with http properties that are not always relevant, we should extend it to a http specific class, something like:
class DaprHttpError(DaprInternalError):

[passuied]

I feel like instead of modifying the genericDaprInternalError class with http properties that are not always relevant, we should extend it to a http specific class, something like:
class DaprHttpError(DaprInternalError):

I like it. What about including the response object in the exception then? I was hesitating about it but didn't want to couple it.

[elena-kolevska]

I think this logic should be encapsulated in the error class itself. The error class would only receive the response object and it would create the error code, message and everything else based on it.

[passuied]

Unfortunately, calling response.read() is async so I'm not sure we can use it in a constructor... copilot is recommending using asyncio.run() but I'm not sure that's a good idea... I'm worried about the negative performance side effects. There's also a dependency on self._serializer...
All in all, I'm not sure if the encapsulation is worth it...

This is the best I could do below but I don't like the dependency to DaprHttpClient instance.

async def from_response(http_client: DaprHttpClient, response: aiohttp.ClientResponse):
        error_info = None
        try:
            error_body = await response.read()
            if (error_body is None or len(error_body) == 0) and response.status == 404:
                return DaprHttpError(
                    error_code=ERROR_CODE_DOES_NOT_EXIST,
                    status_code=response.status,
                    reason=response.reason,
                )
            error_info = http_client._serializer.deserialize(error_body)
        except Exception:
            return DaprHttpError(
                error_code=ERROR_CODE_UNKNOWN,
                raw_response_bytes=error_body,
                status_code=response.status,
                reason=response.reason,
            )

        if error_info and isinstance(error_info, dict):
            message = error_info.get('message')
            error_code = error_info.get('errorCode') or ERROR_CODE_UNKNOWN
            return DaprHttpError(
                message=message,
                error_code=error_code,
                raw_response_bytes=error_body,
                status_code=response.status,
                reason=response.reason,
            )

        return DaprHttpError(
            error_code=ERROR_CODE_UNKNOWN,
            raw_response_bytes=error_body,
            status_code=response.status,
            reason=response.reason,
        )

[passuied]

I have refactored the code and I have come up with a good compromise (I hope). Please let me know