Bell char from weidu is treated as a question now #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
maybe not a bell, but some untraceable character its not backwards compat, but I like it. The really solution which I am working towards is to move this logic into weidu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support this truly brilliant idea from the other size:
The-Mod-Elephant/weidu#23
Actually, this is sort of a draft - detecting weidu prompts by parsing mod output is unreliable, so adding(and reacting) to bell character sounds like an interesting compromise that establishes sort of common interface between tools, does not need any switches or flags on weidu side, does not produce any visible output that might confuse user and also provides some additional usability to weidu users.