-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imageio] Fix interpreting TIFF images as LDR/HDR #18541
Open
victoryforce
wants to merge
1
commit into
darktable-org:master
Choose a base branch
from
victoryforce:tiff-loader-fix-setting-hdr-flag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an arbitrary value, I mean there is no spec for what is HDR or not (at least I did not found one). I would have been tempted to use
> 16
as 16 is probably still a small value for an HDR but again not sure, just a feeling. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, there is no difference of how arbitrary >8 or floating point choice is. In fact, it is more likely people save 16b Adobe RGB for "high fidelity" LDR archiving... IMHO floating point is more likely to be linear (and unclipped)... This is the assumption we have for PFM and float EXRs, so at least it is consistent...
This is not entirely true. It is determined by the format and/or bit depth if not float, but most importantly, the transfer curve in combination w/ high bit depth or float.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same way we assume all 16b PNGs are HDR is also not entirely correct...
So, while it is true that we use <=8bpp as criterion for most loaders to be sure the image is LDR, I still think there are exceptions like TIFF and PNG as those formats have been around decades before HLG and PQ transfer curves showed up, and AVIF/HEIC/JXL after them (and they're more likely to mean HDR if >8bpp is used there, but still not exclusively...)
Long term, this HDR flag probably needs to come out of specific image loaders, and input ICC/CICP profile + bit depth analyzed for all supported formats in one place, at a higher level of abstraction...
Or get rid of this flag as dt doesn't really have a dedicated HDR workflow anyway...