Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web dependency constraint to "^1.1.0" #917

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Nov 14, 2024

Fixes #916


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Nov 14, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl Non-Breaking 0.20.0 0.20.1-wip 0.20.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage
pkgs/intl/lib/intl.dart 💚 63 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
intl StringStack
DateBuilder

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem mosuem changed the title Update web dependency constraint to ">=0.5.1 <2.0.0" Update web dependency constraint to "^1.1.0" Nov 14, 2024
@@ -1,3 +1,7 @@
## 0.20.1-wip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to also publish this (i.e., go straight to 0.20.1).

@copybara-service copybara-service bot merged commit 1b3fecd into main Nov 14, 2024
14 checks passed
@copybara-service copybara-service bot deleted the mosuem-patch-2 branch November 14, 2024 18:00
@rydmike
Copy link

rydmike commented Nov 14, 2024

Had an issue with the ^0.5.0 package:web constraint yesterday and came here to see if it was reported/worked on. This constraint is very problematic for many packages as they cannot update to needed newer package:web versions with it in effect, as it limits intl to package:web versions below 1.0.0, which are too old. Happy to see it addressed, we need a new package release with the fix too.

Dependency override seems to work OK though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] (intl) Support web: 1.0.0 in intl
3 participants