[native_assets_cli] Move BuildMode to [native_toolchain_c]
#1800
Conversation
| @@ -118,16 +99,13 @@ sealed class HookConfigBuilder { | |||
| required String packageName, | |||
| required OS targetOS, | |||
| required List<String> buildAssetTypes, | |||
| required BuildMode? buildMode, | |||
| // required BuildMode? buildMode, | |||
| @@ -207,6 +186,10 @@ final class BuildConfigBuilder extends HookConfigBuilder { | |||
| json[_dependencyMetadataKey] = { | |||
| for (final key in metadata.keys) key: metadata[key]!.toJson(), | |||
| }; | |||
| // TODO: Bump min-SDK constraint to 3.7 and remove once stable. | |||
There was a problem hiding this comment.
This function should no longer take dryRun instead it should hardcode it to false in the json.
There was a problem hiding this comment.
That would break the tests in native_toolchain_c that check that no assets are built if dryRun is true. We can only remove such functionality once we can bump the Dart SDK constraint to 3.7 stable (assuming we get all the refactorings landed in both Dart and Flutter before the branchcut for 3.7).
There was a problem hiding this comment.
This code here is the builder code (i.e. code for Dart SDK & Flutter SDK - which no longer set this to true), no?
The package:native_toolchain_c is for hook writers, it can still read the dry run (possibly produced by older versions of Dart SDK & older versions of Flutter SDK).
There was a problem hiding this comment.
The builder code is used to produce a config in the unit tests of native_toolchain_c (pkgs/native_toolchain_c/test/cbuilder/cbuilder_test.dart). Edit: It seems we don't have any expect that no asset is produced no dry run though, we should have had that. 🤓
The first in a series of refactorings to address:
BuildConfig.targetOStoBuildConfig.codeConfig.targetOS, remove it entirely or extend to cover web #1738We align
BuildModewithOptimizationLevel, it's configured by the hook author in the build hook. Likely, every package should ship with max optimization level and build mode set to release. Only while developing a package (when it is the root package or path-depsed in) would the build mode be set to debug.This will require a manual roll into dartdev and flutter tools due to the removal of
BuildModefrom thenative_assets_builderAPI.The native assets builder will still emit the field in the JSON, until we can bump the
native_assets_cliSDK constraint to 3.7 stable. Then only people with older versions of thenative_assets_clipackage but a newer SDK break.