Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_cli] [doc] Add READMEs for examples #1878

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

dcharkes
Copy link
Collaborator

Add READMEs for the current set of supported use cases.

I added a cross-link to the transformer test case so it doubles as example.

Closes: #1375

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Jan 10, 2025

Coverage Status

coverage: 87.728%. remained the same
when pulling ade4b28 on example-readmes
into 9c07864 on main.

pkgs/native_assets_cli/example/build/README.md Outdated Show resolved Hide resolved
@dcharkes
Copy link
Collaborator Author

Merci @mosuem !

@auto-submit auto-submit bot merged commit b7b8e00 into main Jan 10, 2025
40 checks passed
@auto-submit auto-submit bot deleted the example-readmes branch January 10, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native_assets_cli] In-hook caching
3 participants