[native_toolchain_c] Support Clang on Windows#1893
Merged
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
mosuem
reviewed
Jan 17, 2025
| selectOptimizationLevel = | ||
| (selectOptimizationLevel + 1) % optimizationLevels.length; | ||
| final buildMode = BuildMode.values[selectBuildMode]; | ||
| selectBuildMode = (selectBuildMode + 1) % BuildMode.values.length; |
Member
There was a problem hiding this comment.
Is this some kind of fuzzy testing?
Collaborator
Author
There was a problem hiding this comment.
Heh, it would be fuzz testing if we would randomize the params and run it nightly. Now it's a poor mans combination of trying to cover some combination of params 😄
mosuem
approved these changes
Jan 17, 2025
mkustermann
approved these changes
Jan 17, 2025
Collaborator
Author
|
Thanks @mkustermann and @mosuem ! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #1892
It seems that both Clang via https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.0, and Clang via the MSVC installer come with batteries included and link to the windows headers (added an use of
wprintf).(The Clang-for-Windows on the Dart CI does not come with batteries included: see #1892 (comment).)
Does not add support for arm64 (neither msvc nor clang): #170