Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_toolchain_c] Support Clang on Windows 2 #1910

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

dcharkes
Copy link
Collaborator

Closes: #1892

Using clang on Windows requires being run with the windows dev environment or an MSVC toolchain installed which is discoverable on the system.

On the GitHub bots, MSVC comes pre-installed, so we can't reproduce the case where Clang cannot find the MSVC dev environment.

I've tested this locally by (1) uninstalling visual studio, (2) seeing that the build with Clang fails, (3) hardcoding in a dev environment (from depot_tools) in native_toolchain_c, and (4) seeing that that the tests pass.

@dcharkes dcharkes marked this pull request as ready for review January 17, 2025 11:55
@dcharkes dcharkes requested a review from mkustermann January 17, 2025 11:55
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@auto-submit auto-submit bot merged commit ba34674 into main Jan 17, 2025
41 checks passed
@auto-submit auto-submit bot deleted the clang-windows-2 branch January 17, 2025 12:14
@coveralls
Copy link

Coverage Status

coverage: 90.631% (+0.002%) from 90.629%
when pulling 12ff4da on clang-windows-2
into 434db67 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native_toolchain_c] Support clang on Windows
3 participants