[native_toolchain_c] Support Clang on Windows 2 #1910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1892
Using clang on Windows requires being run with the windows dev environment or an MSVC toolchain installed which is discoverable on the system.
On the GitHub bots, MSVC comes pre-installed, so we can't reproduce the case where Clang cannot find the MSVC dev environment.
I've tested this locally by (1) uninstalling visual studio, (2) seeing that the build with Clang fails, (3) hardcoding in a dev environment (from depot_tools) in
native_toolchain_c
, and (4) seeing that that the tests pass.