-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffigen] Bumped dart_style to 3.0 #1940
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
I set the formatter that runs on the generated code to stick to short style for now, since Dart 3.7 that introduces tall style hasn't released on stable yet. In the future, we'd probably want to find a way to read the current project's language version and use that instead. |
👍 As soon as Dart 3.7 is out. I'd like to bump all the packages in this repo to 3.7 and reformat the whole repo. (It will mean that |
FYI @liamappelbe @HosseinYousefi Us running the formatter from source means we're running whatever version of the formatter we use in FFIgen/JNIgen. Maybe we should consider going back go |
Was hitting an issue in some of my projects that
ffigen: ^16.0.0
depends ondart_style: <3.0.0
which depends onanalyzer: <7.0.0
, but analyzer7.0.0
is being used by some other packages, which makes ffigen the bottleneck. This PR fixes that by simply bumpingdart_style
from^2.3.7
to^3.0.0
.The biggest change from
dart_style
(see the changelog) is the mandatory inclusion of the language version, in order to facilitate the new 3.7 formatter. Luckily, ffigen already passed this parameter voluntarily, so no code change was necessary.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.